Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix people filter by group #7004

Merged
merged 1 commit into from
May 16, 2024
Merged

Fix people filter by group #7004

merged 1 commit into from
May 16, 2024

Conversation

yurabakhtin
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • All tests are passing
  • Changelog was modified

Other information:
#6962 (comment)

@luke- luke- added this pull request to the merge queue May 16, 2024
Merged via the queue into develop with commit c02adbb May 16, 2024
6 checks passed
@ArchBlood
Copy link
Contributor

@yurabakhtin first thanks for the quick action, although I now see a different issue when it comes to the group filter, not sure if this was intended or not;
Screenshot_1

@yurabakhtin
Copy link
Contributor Author

first thanks for the quick action, although I now see a different issue when it comes to the group filter, not sure if this was intended or not;

@ArchBlood I think it is not an issue, it is a feature which was implemented here, it works like this: if some filter is active then values of all filters are reduced to what the filtered users have. For your case, the group "Team" is became hidden because the filtered users are not in the Team group, and such behaviour works for other filter as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants