Fix: Introduce ModuleInfoInterface and fix fatal error on Marketplace keyword search

[martin-rueegg]

• Fix [DEVELOP] ModuleManager fails filtering modules from OnlineModuleManager` #6769

PR Admin

What kind of change does this PR introduce?

• Bugfix
• Refactor

Does this PR introduce a breaking change?

• No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements

• It's submitted to the develop branch, not the master branch if no hotfix
• When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
• All tests tests are passing
• New/updated tests are included
• Changelog was modified

Other information:

[luke-]

@martin-rueegg Can you please provide some steps to reproduce the fatal error?

From my understanding, the ModuleManager should only work with really installed modules ( humhub\components\Module).

Since the methods filterModulesByKeyword and filterModules in ModuleManager are only used in the Marketplace module, I would prefer to move these methods into this module.

[martin-rueegg]

@martin-rueegg Can you please provide some steps to reproduce the fatal error?

I just went to the marketplace in my local instalation and searched for "rest'...

From my understanding, the ModuleManager should only work with really installed modules ( humhub\components\Module).

Since the methods filterModulesByKeyword and filterModules in ModuleManager are only used in the Marketplace module, I would prefer to move these methods into this module.

If that is so, I think moving them would be great.

But is it not also possible to filter the installed modules, too?

Also, there is some change proposed in the way module information is handled in

• Enh: Add Global ID #6718
• specifically here 53df243

[luke-]

@martin-rueegg Can you please provide some steps to reproduce the fatal error?

I just went to the marketplace in my local instalation and searched for "rest'...

Ah ok, I could reproduce this on develop. master seems to work fine.

From my understanding, the ModuleManager should only work with really installed modules ( humhub\components\Module).
Since the methods filterModulesByKeyword and filterModules in ModuleManager are only used in the Marketplace module, I would prefer to move these methods into this module.

If that is so, I think moving them would be great.

Ok. Would you like to do this in the PR or should I create an issue for it?

But is it not also possible to filter the installed modules, too?

The Marketplace module could simply retrieve all installed module IDs from the ModuleManager and use this for filtering? Or did I misunderstood?

Also, there is some change proposed in the way module information is handled in

• Enh: Add Global ID #6718
• specifically here 53df243

Oha :-) We need to discuss such changes separately. For me, it will take a lot of time to understand and discuss the Global ID concept itself. Further refactorings/code cleanups in addition in the PR are making it more hard to understand for me.