New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh: New RuntimeCache #6482
Draft
martin-rueegg
wants to merge
9
commits into
humhub:develop
Choose a base branch
from
metaworx:enh/new-runtimeCache
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Enh: New RuntimeCache #6482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-rueegg
force-pushed
the
enh/new-runtimeCache
branch
2 times, most recently
from
August 4, 2023 13:56
ad9fadf
to
4e66957
Compare
4 tasks
martin-rueegg
force-pushed
the
enh/new-runtimeCache
branch
5 times, most recently
from
August 11, 2023 19:40
9fc337d
to
8df0534
Compare
…ntActiveRecord class
…dInstance()` call, rather than `$model::FindOne()`
5 tasks
martin-rueegg
force-pushed
the
enh/new-runtimeCache
branch
from
August 12, 2023 07:46
8df0534
to
0494089
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new RuntimeCache (RTC) interface and implementation that offer the following ...
Functionality
\yii\db\ActiveRecordInterface
or\humhub\interfaces\UniqueIdentifiersInterface
. This allows that e.g. aUser
is automatically stored (and hence can be retrieved) both by itsid
orguid
.User
objects, generally, but do cache the current user)Possible improvements
Known issues
Requirements
This PR is based on and requires the changes of
PR #6457 andPR #6463. (The changes from this PR alone are to be seen in this commit: 8df0534)Breaking changes
1. Interface requirements for RuntimeCache
Currently, since the introduction of PR #6375, any
\yii\caching\CacheInterface
can be used for the RuntimeCache. However, now the\humhub\interfaces\RuntimeCacheInterface
is required.2. Unique identifier pattern changed
Applies to tests (e.g.
CommentCest.php
), potentially to some front-end code?Since the code for
ActiveRecord::getUniqueId
has changed and is no longer removing the backslashes (\
), but replacing them with unterlines (_
), the resulting identifiers change in the front-end. However, the identifier is now used both for front-end as well as for caching, making it a unique and coherent pattern.PR Admin
What kind of change does this PR introduce?
The PR fulfills these requirements:
develop
branch, not themaster
branch if no hotfixFix #xxx[,#xxx]
, where "xxx" is the Github issue number)