Update outdated PHP error message #454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 7.1 is required by the `version_compare` but the admin notice still says 5.5.0, this PR updates that message to accurately reflect the required version.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
|
Hi @BrookeDot - thanks for the PR. The code and intention makes sense. The Travis CI build failing is related to the proposed changes, so I'll reach out internally to see who might know more here prior to merging. Thanks again for helping improve the plugin, we really appreciate it! |
tareiking
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Code changes make sense! Thank you @BrookeDot. TravisCI build issue is probably something we need to check - so marking this as approved in principal, so it can be merged when ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.1 is required by the
version_comparebut the admin notice still says 5.5.0, this PR updates that message to accurately reflect the required version.