Fix a bug when attempting to use multiple constraints #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug during the step where the
gnm()function determines which coefficients to constrain based on the arguments to the function call. The original code askesif(res == 0 && length(constrain) == 1), which seems to be testing for the situation whereconstrainis a character vector of length 1 but does not match any of the existing coefficient names. However, when two or more coefficients to constrain are specified, then the result ofres == 0has a length greater than 1, and this causes either a warning or error (depending on the version of R, it seems?) when matched with the scalar "AND" operator&&. By usingidentical(res, 0)instead, we get around this issue.