New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember Web Socket Client #7261
base: series/0.23
Are you sure you want to change the base?
Ember Web Socket Client #7261
Conversation
Add validation for server opening handshake response in Ember WebSocket client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! We can now move this suite from jvm
-only to shared
:)
If the Ember client is created To fix this we need some way to force Ember to always use HTTP/1 when negotiating a WebSocket upgrade 🤔 |
Update: I think we're almost ready to merge this, but there is still at least one bug that needs to be investigated. The kubernetes-client is attempting to adopt the Ember WS client but it's not 100% working yet. Help would be very appreciated!! |
Complete PR of
ember-wsclient
implementation.Snapshot
Published as
0.23.23-101-eb5dd80-SNAPSHOT
. Supports JVM, Node.js, Native — please give it a try!https://github.com/http4s/http4s/actions/runs/6000578477/attempts/1#summary-16274325476
Demo