[dsl] Expose PathVar class to facilitate the definition of custom Path extractors #7224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianhjr
force-pushed
the
expose-abstract-PathVar
branch
from
c28ccfd
to
a0a5c3a
Compare
mergify
bot
added
series/0.23
fabianhjr
force-pushed
the
expose-abstract-PathVar
branch
from
a0a5c3a
to
07f980a
Compare
fabianhjr
commented
Jul 26, 2023
fabianhjr
commented
Jul 26, 2023
fabianhjr
force-pushed
the
expose-abstract-PathVar
branch
2 times, most recently
from
5d37a5f
to
2f565f0
Compare
|
/cc @armanbilge / @danicheg |
Thanks for your work on this, unfortunately I don't have much experience with the DSL but someone else can take a look soon :) |
TonioGela
reviewed
Oct 26, 2023
fabianhjr
force-pushed
the
expose-abstract-PathVar
branch
2 times, most recently
from
cca7b81
to
a1598bf
Compare
fabianhjr
force-pushed
the
expose-abstract-PathVar
branch
from
a1598bf
to
6fe83e3
Compare
Koroeskohr
reviewed
Nov 4, 2023
fabianhjr
force-pushed
the
expose-abstract-PathVar
branch
from
6fe83e3
to
8c2a91c
Compare
|
Tests pass but issue is bincompat, unsure about how improve this so that it passes mima checks :c |
armanbilge
reviewed
Nov 10, 2023
fabianhjr
force-pushed
the
expose-abstract-PathVar
branch
from
8c2a91c
to
263b301
Compare
fabianhjr
force-pushed
the
expose-abstract-PathVar
branch
from
263b301
to
c3dd55c
Compare
|
Hi, a slight bump for review. Thanks for the help so far. :3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These makes making custom PathVar more concise.