Small request body decode examples in doc #7061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
series/0.23
danicheg
reviewed
Apr 13, 2023
There was a problem hiding this comment.
I would address this to @ChristopherDavenport but I may guess a lot of time has gone since the issue was created..
docs/docs/dsl.md
Outdated
| @@ -36,6 +37,8 @@ We'll need the following imports to get started: | |||
| import cats.effect._ | |||
| import cats.syntax.all._ | |||
| import org.http4s._, org.http4s.dsl.io._, org.http4s.implicits._ | |||
| import io.circe.generic.auto._ | |||
| import org.http4s.circe.CirceEntityCodec.* | |||
There was a problem hiding this comment.
Actually, it's bikeshedding (It won't fix the CI utterly), but we build docs with Scala 2, so you need the old-style import here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a small example to docs.
#2006