Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds model for X-Forwarded-Host header #6979

Open
wants to merge 2 commits into
base: series/0.23
Choose a base branch
from

Conversation

pektinasen
Copy link

Solves one part of #5010

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:core labels Feb 17, 2023
@rossabaker
Copy link
Member

I can't tell whether this should include a port or not. MDN defines it ambiguously. It also says "The standardized version of this header is Forwarded", whose for value does support a port. And if it's supposed to represent the original Host header, that comes with an optional port. I can find other references to an X-Forwarded-Port header, which speaks to the lack of standardization.

My gut feeling is that this should have a port and look just like the Host header model, but I lack real-world experience on this header, and would accept it as is if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:core series/0.23 PRs targeting 0.23.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants