Adjust public contract of Logger Middlewares #6927
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@http4s/core hey team! I apologize for bothering you, I just want a little attention paid to this PR. It's not rocket science, but I really feel that exposing |
rossabaker
reviewed
Apr 23, 2023
|
Good call, will change it, thanks! |
|
Sorry for pushing this so hard, but can we do another review iteration? There's anxiety, this can end up with a ton of conflicts due to the forthcoming #7122... |
|
|
|
Yeah, sorry for kvetching. It's the correct ordering. I merely tried to overtake you! 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream[F, Byte]is an implementation detail of a specific variant ofEntity[F], so let's adjust the public contract of Logger Middlewares. Naming is the second hard thing in programming, so I'm fully open to debate on it.