Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Access-Control-Expose-Headers using 'cors' configurat… #546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

J-Rojas
Copy link

@J-Rojas J-Rojas commented Jul 19, 2019

Fix #545. Supply 'corser' with a similar set of responseHeaders from the 'cors' options.

@github-actions
Copy link

This pull request has been inactive for 360 days

@github-actions github-actions bot added the stale label Aug 20, 2021
@thornjad thornjad removed the stale label Aug 20, 2021
@thornjad thornjad modified the milestone: v14.0 Aug 20, 2021
@thornjad thornjad added the minor version non-breaking, non-trivial change label Aug 20, 2021
Copy link
Member

@thornjad thornjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way this looks! Only two items left to do:

  • Merge master again, there are new tests to run on this PR
  • Add this header to the CORS test in test/main.test.js

@thornjad thornjad added enhancement patch version Small, non-breaking, bug fix or trivial change and removed minor version non-breaking, non-trivial change labels Oct 15, 2021
ben-z added a commit to ben-z/http-server that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement patch version Small, non-breaking, bug fix or trivial change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for 'Access-Control-Expose-Headers' using --cors
2 participants