You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with U+240A at this particular code location is, that the string is still in UTF-8 at this location and thus doing this replacement would require additional memory to be allocated.
The problem with U+240A at this particular code location is, that the string is still in UTF-8 at this location and thus doing this replacement would require additional memory to be allocated.
I just wish this problem to have a long term solution. There should be ideally be a uniform way to sanitize and escape the characters from the /proc/<pid>/cmdline inputs.
We could allocate the cmdline buffer twice: Once for the original and a second copy for display with special characters replaced by their visual replacements. Though we'd need to introduce some markup in there to distinguish a normal U+240A in the command line vs. the replacement U+240A from displaying the LF. Any ideas? Opinions?
Since \n is used internally by htop to split command lines, replace \n
with \r in command lines to not display them as space.
Merging the command string will not work, but newlines in commands
should be rather the exception.
enhancementExtension or improvement to existing feature
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
\nis used internally by htop to split command lines, replace\nwith\rin command lines to not display them as space.Merging the command string will not work, but newlines in commands should be rather the exception.