Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Remove M1 limitation #1285

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Remove M1 limitation #1285

wants to merge 1 commit into from

Conversation

yngty
Copy link

@yngty yngty commented Aug 24, 2023

Special handling is also required on M1Pro, M2, M2 Pro

@BenBE BenBE added bug 🐛 Something isn't working MacOS 🍏 MacOS / Darwin related issues labels Aug 24, 2023
@Explorer09
Copy link
Contributor

I don't think this fix is correct, since you are not addressing whether Intel processor Macs need the special handling.

@yngty yngty closed this Aug 26, 2023
@yngty
Copy link
Author

yngty commented Aug 26, 2023

I don't think this fix is correct, since you are not addressing whether Intel processor Macs need the special handling.

Intel Processor Mac will not enter isRunningUnderRosetta2 case

@yngty yngty reopened this Aug 26, 2023
@yngty
Copy link
Author

yngty commented Aug 27, 2023

I've changed it.

@SuCicada
Copy link

SuCicada commented Apr 8, 2024

yes, I think this fix is necessary. This fix can be used to distinguish between host_statistics and host_statistics64.

host_statistics64 is necessary at Apple Silicon to show the right memory 🙏

There is a related issue: #631

static void DarwinMachine_getVMStats(vm_statistics_t p) {
mach_msg_type_number_t info_size = HOST_VM_INFO_COUNT;
if (host_statistics(mach_host_self(), HOST_VM_INFO, (host_info_t)p, &info_size) != 0) {
CRT_fatalError("Unable to retrieve VM statistics");
}
}

@BenBE BenBE added this to the 3.4.0 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working MacOS 🍏 MacOS / Darwin related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M1 Mac Ram Usage Incorrect for Application Memory (System Ram, and M1 GPU Ram)
5 participants