PCP-related changes for column handling; code cleanups #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenBE
reviewed
Feb 4, 2023
| char* currentScreen = newFocus->ss->name; | ||
| DynamicScreen_availableColumns(currentScreen); | ||
| } else { | ||
| Panel* availableColumns = AvailableColumnsPanel_get(); |
| } | ||
|
|
||
| void PCPDynamicScreens_availableColumns(Hashtable* screens, char* currentScreen) { | ||
| Panel* availableColumns = AvailableColumnsPanel_get(); |
| for (unsigned int j = 0; j < screen->totalColumns; j++) { | ||
| PCPDynamicColumn* column = &screen->columns[j]; | ||
|
|
||
| column->id = columns->offset + columns->cursor; | ||
| columns->cursor++; |
There was a problem hiding this comment.
Is this cursor still necessary when we index over the array instead of the cursor?
BenBE
force-pushed
the
fix-error-memset
branch
from
f8620ef
to
5c14970
Compare
'actionTogglePauseProcessUpdate' -> 'actionTogglePauseUpdate' 'pauseProcessUpdate' -> 'pauseUpdate' 'hideProcessSelection' -> 'hideSelection' 'hideProcessSelection' -> 'hideSelection' Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
BenBE
force-pushed
the
fix-error-memset
branch
from
5c14970
to
137ff12
Compare
BenBE
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.