Add options to display parents and children processes of filtered pro… #1139
Conversation
…cesses Co-authored-by: yurenchen000 <yurenchen@yeah.net>
|
Exactly what I wanted. Works good for me. |
ProcessList.c
Outdated
| @@ -370,6 +370,16 @@ void ProcessList_collapseAllBranches(ProcessList* this) { | |||
| } | |||
| } | |||
|
|
|||
| static void ProcessList_filterChildern(ProcessList *this, pid_t pid, Hashtable *processFilter) { | |||
ProcessList.c
Outdated
| continue; | ||
|
|
||
| if (this->settings->showChildrenInFilter) | ||
| ProcessList_filterChildern(this, p->pid, filteredProcesses); |
There was a problem hiding this comment.
Very nice work @yurenchen000.
This should have a key binding to be quickly toggled as well. May be Shift-F4 + Ctrl-F4?
(Marked the typo Childern, please fix)
got it, I'll fix typo right now. but I'm not sure if I can add keybinding for it |
code style format Co-authored-by: BenBE <BenBE@geshi.org>
I think it has practical uses, imagine this scenario:
// equivalent to viewing its family tree |
|
I was assuming this refered to the whole tree, not just the next level in each direction. In that case having both makes sense. |
| Process *p = (Process*) (Vector_get(this->processes, i)); | ||
| if (p->pid != pid && Process_isChildOf(p, pid)) { | ||
| Hashtable_put(processFilter, p->pid, (void*) 1); | ||
| ProcessList_filterChildren(this, p->pid, processFilter); |
There was a problem hiding this comment.
This looks quadratic to me (for every descendant of the target process iterate over all processes/threads). Could we do better?
There was a problem hiding this comment.
Even a single loop over processes with walking up from every process would be better (although it would need some cycle detection too) as it can easily be made worst case linear in the total process number. I personally think something like the tree mode "sort by parent" would be even better, but I'm a bit out of context at the moment and not sure how feasible it would be to share that part instead of reimplementing it.
There was a problem hiding this comment.
You could make the hit detection (in subtree/any parent) in O(1) if we tracked some item ranges for nested sets (similar to what Joomla is doing for its menus). Unfortunately, when we tried to implement this in-place while building the tree, this made tree creation kinda slow (O(n²)). One option could be to calculate the nested set ranges on the fly from the Table->displayList based on the indent columns; takes at most O(n*m) with m being the maximum tree depth (which is fixed at 32).
| Hashtable_put(filteredProcesses, p->pid, (void*) 1); | ||
| ppid = Process_getParentPid(p); | ||
| p = Hashtable_get(this->processTable, ppid); | ||
| } while (this->settings->showParentsInFilter && p && p->pid != p->ppid); |
There was a problem hiding this comment.
As we know from #1017 (which I still need to rebase/reimplement), in some cases two processes may be parents of each other and thus this loop becomes an infinite one.
There was a problem hiding this comment.
got it,
I will keep an eye on the progress of that issue
|
Also, do these options make sense in flat view or are they intended for tree mode only? |
@BenBE |
@tanriol Did you mean that limit this functionality to tree view mode, |
Depending on the task it can make sense to have this available outside tree view too. |
This PR based on @ashamza 's work
hishamhm/htop#973 (comment)
#76 (comment)
// co-authors added in commits seem doesn't link to github users
The only thing I did was update the patch to fit the current version code.