WPCS scan for sanitization, escaping, nonces, sql, and strict comparison checks where applicable #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look good upon a quick read through. Your email address seems to be slightly misconfigured in git though, causing the commits to not be linked to your GitHub profile. |
|
Interesting, I’ll check that out. I wonder if it’s because I forked it to
an organization?
…On Sat, May 12, 2018 at 8:51 AM Galdor ***@***.***> wrote:
The changes look good upon a quick read through. Your email address seems
to be slightly misconfigured in git though, causing the commits to not be
linked to your GitHub profile.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#527 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALJxuOephGfGpIXR5yxficiTDWGVxDpks5txtq1gaJpZM4T7l7D>
.
|
|
Sorted out the email issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We typically run WordPress Coding standards scans against libraries and plugins that we use in development which place emphasis on late escaping and strict comparison checks. In the process of reviewing everything, I've made some updates to address applicable issues, and where necessary added phpcs exception comments to prevent already reviewed code from raising issues on subsequent scans.
Thanks for an awesome library!