Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use esc_html__() instead of esc_html_e() #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jedix
Copy link

@jedix jedix commented Sep 25, 2018

When using esc_html_e(), the value is echoed directly.

In this case, it should be returned instead, which is achieved by using esc_html__(), accodring to the documentation.

@roffy2k
Copy link

roffy2k commented Jul 24, 2019

This is a very important amend - it's what causes the problem with Gutenberg "update failed" error as "View article" is echoed before ANY HTML causing the json errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants