Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Future.Travel to Blixt #391

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FutureTravelATM
Copy link

Add Future.Travel to Blixt

Add Future.Travel to Blixt
@vercel
Copy link

vercel bot commented Nov 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hsjoberg/blixt-wallet/o6HinwEAUAZouJ13YJxn42HYFKqD
✅ Preview: https://blixt-wallet-git-fork-futuretravelatm-master-hsjoberg.vercel.app

@hsjoberg
Copy link
Owner

hsjoberg commented Nov 5, 2021

Thank you for your pull request @FutureTravelATM.
I think the code looks great!

I have a concern regarding image itself, as can be observed via the Vercel preview, the text in the image is too small to be readable.
Would it be possible just use FutureTravel's logotype instead and skip the text?

@FutureTravelATM
Copy link
Author

FutureTravelATM commented Nov 5, 2021 via email

@FutureTravelATM
Copy link
Author

FutureTravelATM commented Nov 5, 2021 via email

New logo with the white circle. Its size is still 400 x 400 px.
@hsjoberg
Copy link
Owner

Hi @FutureTravelATM, I don't think the logo looks visually pleasing because of the space constraints we're dealing with here in the transaction log.
I still suggest to cut out the text considering the name will be shown just to right of the image.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants