Add support to pay to amp invoices #1397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
niteshbalusu11
force-pushed
the
pay-to-amp-invoices-support
branch
from
e442215
to
9fa39af
Compare
hsjoberg
approved these changes
Jan 23, 2024
hsjoberg
reviewed
May 5, 2024
src/state/Transaction.ts
Outdated
| @@ -42,13 +53,26 @@ export const transaction: ITransactionModel = { | |||
| throw new Error("syncTransaction(): db not ready"); | |||
| } | |||
|
|
|||
| // Don't insert open transactions for AMP invoices | |||
| if (tx.status === "OPEN" && tx.ampInvoice) { | |||
| return; | |||
There was a problem hiding this comment.
I think this may prevent us from creating our own AMP invoice inside Blixt.
There was a problem hiding this comment.
I don't remember why I did it this way but when we add create support we can fix this separately.
niteshbalusu11
force-pushed
the
pay-to-amp-invoices-support
branch
from
9fa39af
to
cd7a577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nitesh Balusu 84944042+niteshbalusu11@users.noreply.github.com
This is just support for paying to AMP invoices, we can add support for receiving AMP in a seprate PR.