Reduced struct sizes using align for x64 platforms, fields carefully moved #19047
Conversation
GermanAizek
force-pushed
the
align-struct-64
branch
from
dd884dd
to
3c6932b
Compare
There was a problem hiding this comment.
These are good for things like the Vulkan/OpenGL structs.
However, when structs are used to define arrays like SamplerDef which are not accessed very often, I think clarity matters more than saving a few bytes.
So, I have marked a couple that I would like to be reverted.
| const char* name; | ||
| SamplerFlags flags; | ||
| int binding; // Might only be used by some backends. |
There was a problem hiding this comment.
This particular one won't matter for performance, here I prefer the original order, looks better in the table using the struct later.
| // branches | ||
| u32 branchTarget; | ||
| int branchRegisterNum; |
There was a problem hiding this comment.
move this one int down again, I liked having it next to isBranchToRegister. It's aligned with no waste anyway since it's after exactly four bools.
| int* columnOrder; | ||
| int columnCount; |
There was a problem hiding this comment.
This is another one I'd prefer to revert because it makes the tables that use the struct look less nice.
Tested only on Debug
Before RAM util (master):
After RAM util (align-struct-64):