Allow users to change UPnP timeout setting #18867
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… took longer to detects.
anr2me
commented
Feb 15, 2024
| @@ -865,6 +865,7 @@ static const ConfigSetting networkSettings[] = { | |||
| ConfigSetting("ForcedFirstConnect", &g_Config.bForcedFirstConnect, false, CfgFlag::PER_GAME), | |||
| ConfigSetting("EnableUPnP", &g_Config.bEnableUPnP, false, CfgFlag::PER_GAME), | |||
| ConfigSetting("UPnPUseOriginalPort", &g_Config.bUPnPUseOriginalPort, false, CfgFlag::PER_GAME), | |||
| ConfigSetting("UPnPTimeout", &g_Config.iUPnPTimeout, 2000, CfgFlag::PER_GAME), | |||
There was a problem hiding this comment.
Hmm.. since upnp timeout usually external issue, may be not supposed to be PER_GAME setting.
|
We probably just need to update our miniupnp library, may be. |
|
Hm, ok. we can leave this sitting around for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case their UPnP device took longer to be detected.
Will need to get feedbacks first from user who reported that their iPhone 12 pro can't detect UPnP device anymore (might be related to newer iOS version?) https://forums.ppsspp.org/showthread.php?tid=29904
PS: If the reporter can solve the issue by increasing the timeout, i'll probably need to increase the default value too, a long with this PR.
Edit: Apparently it wasn't timeout issue, may be miniupnpc no longer compatible with newer iOS :( since it (said to) works on PC on the same network/router.
Or may be we just need to update the miniupnp library?