Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings banner for game specific settings #18730

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

hrydgard
Copy link
Owner

This shows a banner if you're editing game-specific settings:

image

Unfortunately, we don't have a way to display exactly which settings are game-specific, but this might reduce confusion a bit?

The banner also has room for a Help button that leads to for example https://www.ppsspp.org/docs/settings/graphics .

However, I don't 100% like this, it's a bit bulky - and I'm also not really sure what to display there if editing global settings.

Thoughts?

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Jan 19, 2024
@hrydgard hrydgard marked this pull request as draft January 19, 2024 15:34
@Domiiniik
Copy link
Contributor

For the global settings, maybe don't give it the name at all? And display only if you edit game settings, that'd be also good for separating it visually

@anr2me
Copy link
Collaborator

anr2me commented Jan 20, 2024

May be using a different font color/stlyle (ie. italic) if it use a game-specific setting?

@jcchikikomori
Copy link
Contributor

I understood that this is kind of bulky, as i already imagine what will look like on smaller-smallest screens.

Maybe we can put the icon as a indicator on each sections, e.g.: ⚙️Rendering mode.
Or maybe we can put the Game ID after each section, e.g.: Rendering mode - for UCES00304.

For the global settings, maybe don't give it the name at all? And display only if you edit game settings, that'd be also good for separating it visually

For this one, i also agree, we don't need to display (except Help maybe?) for Global Settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants