Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Editor Type & Export Options #14

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

HTML Editor Type & Export Options #14

wants to merge 21 commits into from

Conversation

hreikin
Copy link
Owner

@hreikin hreikin commented Apr 23, 2022

Description

This PR is a follow up to #13. More work is currently needed before this will be ok to merge, in its current state this PR's changes include:

  • Restructures the toolbars
  • Adds a HTML editor
  • Converts editor content when a different editor type is chosen
  • Configure markdown > HTML conversion extensions (pymdownx: Github style configuration as suggested in FAQ)
  • Syntax highlighting in the document preview
  • HTML syntax highlighting
  • Document theming
  • Template system (Jinja2 - basic, no template inheritance as of yet)

Changes still to be made:

  • Toolbar buttons apply appropriate syntax when in Markdown or HTML mode
  • Edit the full page HTML before export functionality
  • Export options

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested

Still To Be Updated
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

…de. Update function to choose the correct lexer for both edit modes.
… the user the first time the function is called.
…oad a theme in the preview, modify the function to load an editor style, create functions to change the theme or style.
@hreikin hreikin mentioned this pull request Apr 23, 2022
7 tasks
@hreikin hreikin changed the title Markdownify HTML Editor Type & Export Options Apr 23, 2022
@hreikin hreikin self-assigned this Apr 23, 2022
@hreikin hreikin added the enhancement New feature or request label Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant