Pin build to Python 3.10 #46
Merged
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI does not like pinning! |
Also make it possible to override it using the PYTHON make variable:
$ make PYTHON="$HOME/bin/python3.10"
Fixes hpyproject#45
erlend-aasland
force-pushed
the
build-python
branch
from
5e9abd2
to
d6182ec
Compare
hodgestar
reviewed
Mar 20, 2024
|
Does anything pin the Python version to 3.10 in CI? Or is it just accidental that that is GitHub's current default? |
Looks accidental to me. You might want to pin it there as well! |
erlend-aasland
force-pushed
the
build-python
branch
from
ce7a1ca
to
0c12f95
Compare
|
You have a nitpicky CI ;) |
Yes, I think it is by accident. At the time we did the setup, there was probably 3.10.
🙂 |
fangerer
approved these changes
Mar 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
hodgestar
reviewed
Mar 20, 2024
hodgestar
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make it possible to override it using the PYTHON make variable:
Fixes #45