ChafaTermDb: Eat advertises color support via TERM #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfllaw
commented
Apr 18, 2024
sfllaw
force-pushed
the
eat-terminal-color
branch
from
6824130
to
2126cd9
Compare
|
@hpjansson I think this patch is ready to be reviewed. I will work with Eat to support 16-color mode, so I have built that detection into this PR. |
|
Looks good to commit once the minor conflict with the sixel PR is resolved. |
The Eat terminal advertises its color support by setting its TERM to: * eat-truecolor when it supports more than 256 colors, * eat-256color when it supports more than 16 colors, * eat-16color when it supports more than 8 colors, * eat-color when it supports more than 1 color, * eat-mono when it supports no colors. Note that eat-16color isn't actually supported yet, but a bug has been filed upstream: https://codeberg.org/akib/emacs-eat/issues/154
sfllaw
force-pushed
the
eat-terminal-color
branch
from
2126cd9
to
8c03cee
Compare
|
Rebased and tested.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Eat terminal advertises its color support by setting its TERM to:
Note that eat-16color isn't actually supported yet, but a bug has been filed upstream: https://codeberg.org/akib/emacs-eat/issues/154