Squeak: use up-to-date STON, remove bundled STON #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what is causing this, and it seems I can no longer reproduce this locally as I'm on a Mac 😬 |
…ctor in STON's tests)
|
@theseion does this work for you? |
theseion
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #527
Supersedes #528
/cc @theseion
I split the change into two commits for a little more overview. The first adapts the baseline for squeak to load the up-to-date STON package. The second deletes the bundled STON package.
Locally, I was only able to test the 64bit images (so starting with 5.1), so I'm curious to see what CI will say for squeak4.x :)
As far as I've seen, neither Gemstone nor Pharo depend on the bundled STON, at least it is not referenced in any place that I found.