Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1889 Launch school external tools #5003

Merged
merged 8 commits into from
May 16, 2024
Merged

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented May 14, 2024

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.


@Post('school/:schoolExternalToolId/launch')
@HttpCode(HttpStatus.OK)
@ApiOperation({ summary: 'Get tool launch request for a context external tool id' })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw this in vue and just wanted to raise awareness ;) Not sure if swapping 'context' with 'school' would be enough , but you'll figure it out :P

Copy link

sonarcloud bot commented May 16, 2024

@IgorCapCoder IgorCapCoder enabled auto-merge (squash) May 16, 2024 08:18
@IgorCapCoder IgorCapCoder merged commit 9f418a5 into main May 16, 2024
53 of 55 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1889-launch-school-tool branch May 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants