Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-7180 Prepare a mechanism for deleting in pools #4986

Merged
merged 25 commits into from
May 15, 2024
Merged

BC-7180 Prepare a mechanism for deleting in pools #4986

merged 25 commits into from
May 15, 2024

Conversation

WojciechGrancow
Copy link
Contributor

@WojciechGrancow WojciechGrancow commented May 6, 2024 •
edited

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-7180

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@WojciechGrancow WojciechGrancow self-assigned this May 6, 2024
WojciechGrancow and others added 20 commits May 7, 2024 07:40
@WojciechGrancow
Merge branch 'main' into BC-7180-deleting-in-pools
ca0450e
@WojciechGrancow
add envs to defaultjson
6f94fd9
@WojciechGrancow
config and test modification
92b9c5a
@WojciechGrancow
fix imports
30620b2
@WojciechGrancow
comment some test
dea924e
@bn-pass
add dedicated ConfigMap for the data-deletion-trigger-cronjob
e8d43e8
@WojciechGrancow
fix problems with test in deletion api
832b60a
@WojciechGrancow
fix in test in deletionrequest service
d4c09d9
@WojciechGrancow
Merge branch 'main' into BC-7180-deleting-in-pools
4653dbb
@WojciechGrancow
add try catch in handle in fileStorageClient.service
cf0e4fd
@bn-pass
add FEATURE_PROMETHEUS_METRICS_ENABLED: "true" to the data-deletion-t…
151faf2 
…rigger-cronjob ConfigMap
@bn-pass
add Prometheus metrics to the Admin API server deployment
cd82cd5
@bn-pass
add exposing Prometheus metrics from the Admin API service, add servi…
92afc12 
…ce monitor to monitor them
@WojciechGrancow
Merge branch 'main' into BC-7180-deleting-in-pools
884c5df
@WojciechGrancow
add test in deletion repo and scope
6335a44
@WojciechGrancow
add test to deletionRequest service
086cadb
@WojciechGrancow
add tests to uc in deletion module
298c336
@WojciechGrancow
Merge branch 'main' into BC-7180-deleting-in-pools
4b801fc
@WojciechGrancow
add test in filesstorageclient and rename env
efa8891
@bn-pass
Merge branch 'main' into BC-7180-deleting-in-pools
6b7f28d
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@WojciechGrancow WojciechGrancow merged commit 35d60bd into main May 15, 2024
54 of 56 checks passed
@WojciechGrancow WojciechGrancow deleted the BC-7180-deleting-in-pools branch May 15, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loki-Afro Loki-Afro Loki-Afro approved these changes

@virgilchiriac virgilchiriac virgilchiriac approved these changes

@blazejpass blazejpass blazejpass approved these changes

Assignees

@WojciechGrancow WojciechGrancow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@WojciechGrancow @Loki-Afro @virgilchiriac @blazejpass @bn-pass