Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EW-793 - Refactor Common Cartridge Export #4918

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

Conversation

SimoneRadtke-Cap
Copy link
Contributor

@SimoneRadtke-Cap SimoneRadtke-Cap commented Apr 11, 2024

Description

Refactoring the Common Cartridge Export and working on comments from a Dataport review.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/EW-793

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@SimoneRadtke-Cap SimoneRadtke-Cap self-assigned this Apr 11, 2024
SimoneRadtke-Cap and others added 28 commits April 12, 2024 11:33
Co-authored-by: Simone Radtke <SimoneRadtke-Cap@users.noreply.github.com>
Co-authored-by: Simone Radtke <SimoneRadtke-Cap@users.noreply.github.com>
Co-authored-by: Simone Radtke <SimoneRadtke-Cap@users.noreply.github.com>
Co-authored-by: Patrick Sachmann <psachmann@users.noreply.github.com>
Co-authored-by: Patrick Sachmann <psachmann@users.noreply.github.com>
Co-authored-by: Patrick Sachmann <psachmann@users.noreply.github.com>
Co-authored-by: Patrick Sachmann <psachmann@users.noreply.github.com>
Copy link

sonarcloud bot commented May 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants