BC-7032 - new topbar #3449
Open
BC-7032 - new topbar #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uidp
approved these changes
May 22, 2024
| } | ||
| } | ||
|
|
||
| const toggleIcon = document.querySelector('#group-toggle-icon'); |
There was a problem hiding this comment.
As this is an id, is #group-toggle-icon really unique in the document? Or should we rather use a class?
There was a problem hiding this comment.
True, it's not. Good point, thank you!
| @@ -31,7 +31,7 @@ | |||
| {{/if}} | |||
| <span class="link-name">{{../name}}</span> | |||
| </div> | |||
| <i class="mdi mdi-chevron-down" aria-hidden="true"></i> | |||
| <i id="group-toggle-icon" class="mdi mdi-chevron-down" aria-hidden="true"></i> | |||
There was a problem hiding this comment.
Doesn't look like this is a unique css id.
| @@ -0,0 +1,60 @@ | |||
| <nav id="top-navbar" class="topbar"> | |||
| <button class="icon-btn sidebar-toggle" title="{{$t "lib.loggedin.label.sidebarMenu"}}" aria-label="{{$t "lib.loggedin.label.sidebarMenu"}}"> | |||
There was a problem hiding this comment.
Looks like the toggle button keeps a blue focus border. Is that intended?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To ensure a consistent layout and create the possibility for broader content width, we want to refactor the topbar to use Vuetify components.
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-7032
hpi-schul-cloud/dof_app_deploy#872
Changes
Data Security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Approval for review