Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload config on update - Updated #471

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Reload config on update - Updated #471

wants to merge 5 commits into from

Conversation

mumblepins
Copy link

Watches for changes to config.json and reloads config. Updated version of #357. Addresses some of the notes on that pull request, cherry picked on to current code base, and improved some refresh handling.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

The PR fulfills these requirements:

  • All tests are passing?
  • New/updated tests are included?
  • If any static assets have been updated, has ui/bindata.go been regenerated?
  • Are there doc blocks for functions that I updated/created?

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

elliotpeele and others added 5 commits September 5, 2023 15:31
@elliotpeele @mumblepins
Reload config on update
61139dc 
(cherry picked from commit 6abd3b7)
@elliotpeele @mumblepins
claim refs that are still in use
be17992 
(cherry picked from commit 1e54ee4)
@mumblepins
fix main.go imports and deleted function, add fsnotify to go.mod
678da65
@mumblepins
Improved config reload handling
2da3beb 
* allowing for deleted repositories
* recreation of event handling fixed
* mutex for only one config at a time
@mumblepins
lint fix
48e002e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mumblepins @elliotpeele