Added options to speficy defaults for poll frequence and vcs #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added feature request #185 |
|
This should be extended to the base-url and anchor as well. It would be useful to define these globally if you work at a company with a custom git browsing website. |
sahildua2305
suggested changes
Dec 27, 2017
There was a problem hiding this comment.
Hi @pfrandsen would you still be interested in finishing off this patch? I left a minor improvement as a comment. Let's ship this!
| @@ -33,6 +33,11 @@ type Repo struct { | |||
| EnablePushUpdates *bool `json:"enable-push-updates"` | |||
| } | |||
|
|
|||
| type RepoDefaults struct { | |||
There was a problem hiding this comment.
The name of the struct should be singular. So, we can have RepoDefaultSetting or RepoDefault here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added options to speficy defaults for ms-between-polls and vcs in config.json - if any of the attributes are not defined the hardcoded values in the code (30000, "git") will be used as in the current version of the application.
Example config.json
{
"dbpath" : "data",
"repo-defaults" : {
"ms-between-poll" : 30000,
"vcs" : "git"
},
"repos" : {
"Hound" : {
"url" : "https://www.github.com/etsy/Hound.git"
}
}
}