Rsync #167
Rsync #167
Conversation
| } | ||
|
|
||
| func (g *RsyncDriver) HeadRev(dir string) (string, error) { | ||
| return "n/a", nil |
There was a problem hiding this comment.
The way this is setup, Hound will continue to try to poll this vcs even though it can never update. I think it would be better to return something sensible for the revision so that pulling works as expected. That said, I do think that an rsync vcs should not poll by default. It should require an explicit push update to tell the server to go fetch the new version. The server supports push updates, but there isn't a convenient way to trigger one right now.
There was a problem hiding this comment.
Thanks for the comment, unfortunately I'm not sure what to do about that. I think with rsync it actually makes sense to pull. I would then do a rsync --delete src dst. Which would update the state of the source in sync. Unfortunately for that I would need the url in te Pull call, since it is not saved in the data directory as with git or other vcses.
How should I proceed in updating this branch?
There was a problem hiding this comment.
Can you give me a few more hints how I could improve this PR to get it eventually merged?
* Implementation of a simple rsync vcs provider.
This is a simple rsync vcs provider. It can be also used for indexing of local directories. Only drawback in that case is that it still makes a copy of the local files.