Support for local VCS allowing to index local path #156
Conversation
olczykkrzysztof
changed the title
|
This looks good to me, thanks. I'll let @kellegous take a look and merge when ready. |
|
@gemignani Sorry, I have been really behind on pull requests. I'll take a closer look at this soon. I'll leave some minor comments now. I think the one thing that is missing in the local support is that local vcs really shouldn't poll by default because it introduces the possibility that the repo will be indexed while it is being mutated. However, that's a thing I can easily help out with. |
searcher/searcher.go
Outdated
| @@ -367,6 +365,13 @@ func newSearcher( | |||
| SpecialFiles: wd.SpecialFiles(), | |||
| } | |||
|
|
|||
| var vcsDir string | |||
| if (wd.IsLocal()) { | |||
There was a problem hiding this comment.
I think this would better separate concerns if the vcs interface had a function kind of like this:
WorkDirFrom(dbpath string, repo *config.Repo) string
There was a problem hiding this comment.
like in in vcs.Driver?
Then each driver (apart from local) will need to implement basically the same code to get the working dir.
There was a problem hiding this comment.
Right. I'm saying that Driver should not have IsLocal. Rather than having the Searcher have special knowledge of what IsLocal means, it would be better to just move the path creation into the driver. That does mean that this new method will have identical implementations for all the existing drivers, but that's also the case with IsLocal.
olczykkrzysztof
force-pushed
the
local_file_repos
branch
2 times, most recently
from
0710891
to
171902c
Compare
…ing a part of the version-controller repository.
olczykkrzysztof
force-pushed
the
local_file_repos
branch
from
171902c
to
c68f0f1
Compare
…rily being a part of the version-controller repository.
|
Any plans to finish this support? |
|
@snagytx, I'd love to, but very short time recently. :( |
Support for local VCS allowing to index local path not necessarily being a part of the version-controller repository.
Non-copying version of #138.