Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button spacing fix #1472

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kayrocesar
Copy link
Contributor

Co-Authored-By: Victor Cabral 87657291+victordscabral@users.noreply.github.com
Co-Authored-By: J 111386960+joaobisi@users.noreply.github.com

before:
telaantes

after:
depois

Co-Authored-By: Victor Cabral <87657291+victordscabral@users.noreply.github.com>
Co-Authored-By: J <111386960+joaobisi@users.noreply.github.com>
@kayrocesar kayrocesar changed the title #1469 - button spacing fix button spacing fix Jan 17, 2023
@wwahammy
Copy link
Member

Thanks for the submission and welcome to Houdini. I only have one request: could you center the buttons? So definitely split them up by the same distance but put them in the center of that line.

Otherwise it looks good!

Co-Authored-By: Victor Cabral <87657291+victordscabral@users.noreply.github.com>
Co-Authored-By: J <111386960+joaobisi@users.noreply.github.com>
@kayrocesar
Copy link
Contributor Author

New fix:

info_buttons

@@ -106,7 +106,7 @@ function view(state) {
, customFields(state.params$().custom_fields)
, dedicationLink(state)
, app.nonprofit.no_anon ? '' : anonField(state)
, h('fieldset.u-inlineBlock.u-marginTop--10', paymentMethodButtons(["card", "sepa"], state))
, h('fieldset.u-inlineBlock.u-marginTop--10.u-marginLeft--65', paymentMethodButtons(["card", "sepa"], state))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried using something that sets text-align: center on this element? I think that would be the most ideal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried with solutions like that, but some problems occurred. Now that we have a better understanding of the structure of the project we will implement a solution of the type. Thanks for the feedback!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayrocesar when you say problems occurred, could you describe them in more detail? It's good to have it documented and also so I can help you and you can help me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @wwahammy, sorry for the delay in answering.
We tried to use text-align but it didn't work before, because we were doing it in the wrong place. But we were able to align the buttons using it now, if you could take a look. Thanks a lot.

Co-Authored-By: Victor Cabral <87657291+victordscabral@users.noreply.github.com>
Co-Authored-By: J <111386960+joaobisi@users.noreply.github.com>
@kayrocesar
Copy link
Contributor Author

Comparison:

buttons_before
buttons_center

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants