Do not load ActiveJobs if ActiveJob is not loaded #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzak
reviewed
Apr 19, 2024
| # end | ||
| # | ||
| initializer "turbo.no_active_job", before: :set_eager_load_paths do | ||
| unless defined?(ActiveJob) |
There was a problem hiding this comment.
Would this work instead?
ActiveSupport.on_load :active_job do
There was a problem hiding this comment.
I don't know. I'm following the pattern used in the Action Cable check below. At first blush, it seems preferable to the method used here, but it would need to be tested.
There was a problem hiding this comment.
Correct, sorry I was thinking of the opposite case but this initializer occurs in the absence of AJ 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478
Replaces #479
Based on #601