Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added DB connection health check #4014

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ckmonish2000
Copy link

@ckmonish2000 ckmonish2000 commented Apr 28, 2024

As requested on the issues 3830 I've added a health check to verify the db connection using a simple select 1 query.

Closes #

Description

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

- included a select 1 query after pg_isready on health check test
@ckmonish2000 ckmonish2000 changed the title feat: modified db health check feat: Added DB connection health check Apr 28, 2024
@balub
Copy link
Member

balub commented Apr 29, 2024

Hey @ckmonish2000 thank you for your contribution, however, I believe your addition does not solve the issue raised in #3830.

@balub
Copy link
Member

balub commented Apr 29, 2024

Could you take a look at it once more, there have been updated there.

@ckmonish2000
Copy link
Author

sure I'll add the required changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants