Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to keep the Hoppscotch codebase mostly in line with the changes introduces in
dioc
version3.0.1
which tries to update certain bits of how aContainer
context is passed down to services.What's changed
dioc
to3.0.1
on all packages.onServiceInit
method overridable by services to implement their initialisation logic. The constructor after moving the logic is removed.StaticSpotlightSearcherService
, an abstract Service that is implemented that standardized static search logic has a constructor which takes arguments, since there are many implementations of this class, for the time being, the constructor is kept on the inherited services but logic is mostly moved tononServiceInit
. TODOs are kept to notify that this a thing we will have to refactor down the line.This PR shouldn't introduce any new end-user functionality of changes in behaviour.
Notes to the reviewer
onServiceInit
(except forStaticSpotlightSearcherService
and its children).