Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolved mailer module email issue #4000

Merged
merged 2 commits into from Apr 29, 2024
Merged

fix: resolved mailer module email issue #4000

merged 2 commits into from Apr 29, 2024

Conversation

balub
Copy link
Member

@balub balub commented Apr 23, 2024

Closes HSB-391

Description

This PR has a fix for the issue with the missing handlebar files in the mailer module.

#3949

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

@balub balub changed the base branch from main to release/2024.3.1 April 23, 2024 10:57
@balub balub removed the request for review from ankitsridhar16 April 23, 2024 10:57
@m-amiri
Copy link

m-amiri commented Apr 24, 2024

plz fix this issue

mirarifhasan
mirarifhasan approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@mirarifhasan mirarifhasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@balub balub changed the base branch from release/2024.3.1 to release/2024.3.2 April 29, 2024 06:18
@balub balub merged commit f89561d into release/2024.3.2 Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirarifhasan mirarifhasan mirarifhasan approved these changes

@AndrewBastin AndrewBastin Awaiting requested review from AndrewBastin

@liyasthomas liyasthomas Awaiting requested review from liyasthomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balub @m-amiri @mirarifhasan