New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new button to save request modal #3976
Added new button to save request modal #3976
Conversation
@click="onCloseConfirmSaveTab" | ||
/> | ||
</span> | ||
<span class="flex space-x-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An extra cancel button is not required. Let the cross icon on the top right of the modal handle the cancellation case. So you can remove the entire span container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for review!
Maybe you're right. I thought the user might have doubts about the action of the upper right cross. Adding a new button will add clarity. If your position remains unchanged, then I will correct it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shipko The cross button inherently means to cancel the action. The same design and implementation is followed for most modals in the app. So we will follow the same. Let's remove the cancel button as it's redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoelJacobStephen done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shipko After having an internal discussion regarding this PR, we have decided to go with the following approach:
- Yes Button - Opens the save dialog modal and closes the tab
- No Button - Doesn't save and closes the tab
- Cancel Icon - (Present at the top right of the modal) - Neither saves nor closes the tab
Based on the above approach, I have suggested few changes to your implementation. Please go through the review comments and then we can go ahead with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this minor addition, LGTM 💯
Co-authored-by: Nivedin <53208152+nivedin@users.noreply.github.com>
ea4f1d3
to
c05f194
Compare
Description
I noticed that you can't cancel modal window when saving a request.
I suggest adding a third "cancel" button, which will close the window without performing an action.
Checks