Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate Node.js implementation for js-sandbox to isolated-vm #3973

Merged
merged 19 commits into from Apr 19, 2024
Merged

chore: migrate Node.js implementation for js-sandbox to isolated-vm #3973

merged 19 commits into from Apr 19, 2024

Commits on Apr 19, 2024

  1. chore: migrate JS sandbox to isolated-vm

    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    5cc8716 View commit details
    Browse the repository at this point in the history

  2. fix: pre-request script execution 

    - Wrap `pw` methods in `ivm.Reference` for transferring to the isolate context.
- Ensure pre-request script methods are executed via `applySync` calls in the isolate context.
    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    23e959a View commit details
    Browse the repository at this point in the history

  3. refactor: serialize test script API methods before sending to the iso… 

    …late
    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    bac9743 View commit details
    Browse the repository at this point in the history

  4. chore: migrate test framework to vitest

    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c2bd74a View commit details
    Browse the repository at this point in the history

  5. chore: resolve build errors wrt wrt CJS interop with ESM

    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d75a76d View commit details
    Browse the repository at this point in the history

  6. refactor: leverage Proxy to intercept scripting API calls

    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    318402d View commit details
    Browse the repository at this point in the history

  7. refactor: spawn child process to add no-node-snapshot flag when required

    @AndrewBastin @jamesgeorge007
    AndrewBastin authored and jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    023072e View commit details
    Browse the repository at this point in the history

  8. chore: bump jest timeout for test.spec.ts

    @AndrewBastin @jamesgeorge007
    AndrewBastin authored and jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0e2d2d0 View commit details
    Browse the repository at this point in the history

  9. fix: condition to spawn child process

    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    27d58c0 View commit details
    Browse the repository at this point in the history

  10. chore: make isolated-vm a peer-dependency

    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7eca5ba View commit details
    Browse the repository at this point in the history

  11. test: specify node as the command while invoking the CLI binary 

    Since Windows doesn't respect the shebang line, we'd need to specify node as the command with the CLI binary while running tests
    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0659182 View commit details
    Browse the repository at this point in the history

  12. refactor: update js-sandbox directory hierarchy

    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3268220 View commit details
    Browse the repository at this point in the history

  13. test: update directory hierarchy 

    - Remove the `testing` directory and move the tests within it to root.
- Rename the `envs` directory to `env` to follow a consistent convention indicating the nested scripting API objects.
    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    5ba17f0 View commit details
    Browse the repository at this point in the history

  14. chore: cleanup 

    - Organize imports.
- Update CI config.
  - Bump dependent actions.
  - Fix a typo while referring to the Node.js version and run tests on LTS.
  - Move `Setup node` step above `Setup pnpm`.
- Bump CLI version.
    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    01515fd View commit details
    Browse the repository at this point in the history

  15. test: fix flaky tests

    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3bd099c View commit details
    Browse the repository at this point in the history

  16. chore: account for nested folders while validating requests

    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2f3ca3f View commit details
    Browse the repository at this point in the history

  17. chore: compile shared utils for sandbox 

    Rename `~/src/utils.ts` to `~/src/shared-utils` to differentiate from platform-specific utility functions (`~/src/node/utils.ts`).
    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    62d4545 View commit details
    Browse the repository at this point in the history

  18. test: fix flaky tests 

    Add safeguards to prevent test failure if the endpoint results in a non `200` status code.
    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    da356c7 View commit details
    Browse the repository at this point in the history

  19. chore: ensure consistent file naming convention

    @jamesgeorge007
    jamesgeorge007 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8321fc8 View commit details
    Browse the repository at this point in the history