refactor(sh-admin): improved handling of server configurations in admin dashboard #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelJacobStephen
force-pushed
the
refactor/dashboard-configs
branch
from
a392c1a
to
1a374bf
Compare
JoelJacobStephen
force-pushed
the
refactor/dashboard-configs
branch
from
1a374bf
to
c1f2b78
Compare
JoelJacobStephen
force-pushed
the
refactor/dashboard-configs
branch
from
d0485c8
to
0fa3715
Compare
nivedin
requested changes
Apr 24, 2024
nivedin
requested changes
Apr 24, 2024
nivedin
reviewed
Apr 24, 2024
nivedin
approved these changes
Apr 25, 2024
jamesgeorge007
requested changes
Apr 26, 2024
packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts
Outdated
Show resolved
Hide resolved
jamesgeorge007
force-pushed
the
refactor/dashboard-configs
branch
from
9a2ba73
to
f34109d
Compare
jamesgeorge007
approved these changes
May 1, 2024
There was a problem hiding this comment.
I've pushed a few changes in f34109d, mostly about leveraging the generated InfraConfigEnum enum while referring to the field names and moving variables within function definitions that aren't consumed elsewhere. Please give it a look.
packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts
Outdated
Show resolved
Hide resolved
JoelJacobStephen
changed the base branch from
release/2024.3.1
to
release/2024.3.3
…rom configs helper
…from individual user page
… function definitions
JoelJacobStephen
force-pushed
the
refactor/dashboard-configs
branch
from
f34109d
to
6307b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes HFE-479
Description
This PR aims to refactor the handling of server configurations in the admin dashboard.
Checks