fix: lint errors removed by using satisfies or as for type
#3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anwarulislam
requested review from
AndrewBastin,
amk-dev and
nivedin
as code owners
jamesgeorge007
approved these changes
Mar 26, 2024
amk-dev
reviewed
Mar 26, 2024
| @@ -125,12 +134,12 @@ watch( | |||
| if (props.show) { | |||
| persistenceService.setLocalConfig( | |||
| "unsaved_collection_properties", | |||
| JSON.stringify(<EditingProperties>{ | |||
| JSON.stringify({ | |||
There was a problem hiding this comment.
both the angle-bracket syntax and using as to assert just tells typescript that we know what we're doing, and dont bother checking it. but in the future if someone passes an invalid object that does not adhear to the type, typescript won't catch that.
ideally in this case, we can extract the object into variable and assign a type for that, and tries to fix any errors that comes up.
amk-dev
force-pushed
the
fix/lint-errors
branch
from
720f46d
to
79d3e8a
Compare
amk-dev
reviewed
Mar 26, 2024
There was a problem hiding this comment.
the root cause of the errors with angle-bracket assertion (<>) was because parserOptions.ecmaFeatures.jsx was enabled.
this is the default behaviour in @vue/typescript/recommended package. since we don't use jsx, we can disable this option. added this change in 79d3e8a
AndrewBastin
force-pushed
the
fix/lint-errors
branch
from
5655288
to
ae7cdfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
satisfiesorasfor type enforcement to skip lint errors.