New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added mutation and function to platform for updating user profile name #3929
Merged
jamesgeorge007
merged 9 commits into
release/2024.3.0
from
feat/update-user-display-name
Mar 25, 2024
Merged
feat: added mutation and function to platform for updating user profile name #3929
jamesgeorge007
merged 9 commits into
release/2024.3.0
from
feat/update-user-display-name
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amk-dev
requested changes
Mar 22, 2024
anwarulislam
approved these changes
Mar 25, 2024
jamesgeorge007
approved these changes
Mar 25, 2024
nivedin
force-pushed
the
feat/update-user-display-name
branch
from
March 25, 2024 06:57
7c7eacb
to
7e1b1f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A potential enhancement we could have here is ensuring the GQL mutation gets triggered only when there's a change detected in the profile name.
amk-dev
reviewed
Mar 25, 2024
packages/hoppscotch-selfhost-web/src/platform/auth/auth.platform.ts
Outdated
Show resolved
Hide resolved
amk-dev
reviewed
Mar 25, 2024
packages/hoppscotch-selfhost-web/src/platform/auth/auth.platform.ts
Outdated
Show resolved
Hide resolved
amk-dev
approved these changes
Mar 25, 2024
jamesgeorge007
force-pushed
the
feat/update-user-display-name
branch
from
March 25, 2024 09:07
95b5a09
to
d65b2de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HFE-455
Description
This PR adds the mutation and function to the platform to update user profile name from the profile section.
Checks