chore: split axios request options into platform #3927
Merged
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amk-dev
changed the title
jamesgeorge007
force-pushed
the
fix/use-backend-headers
branch
from
a5786d1
to
c283780
Compare
jamesgeorge007
force-pushed
the
fix/use-backend-headers
branch
from
c283780
to
501aad3
Compare
jamesgeorge007
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces a new property
axiosPlatformConfigto auth platform definition. this allows us to pass different axios configs based on the platform.eg: Central uses Bearer Token to authenticate with the backend, while the SH uses Cookies, the configs for these can now belong in the respective platforms.
we already do this for our Gql Client, this PR adds the same for axios configs to be used for requests sent outside of the graphql client.