Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workspace list section bugs #3925

Merged
merged 3 commits into from Mar 22, 2024
Merged

fix: workspace list section bugs #3925

merged 3 commits into from Mar 22, 2024

Conversation

nivedin
Copy link
Member

@nivedin nivedin commented Mar 21, 2024

Closes HFE-458

Description

This PR fixes the bugs in workspace section in profile page

  • Add loading spinner while deleting a workspace
  • Refetch workspace list after deleting a workspace rather waiting for the workspace list fetch poll to effect the list
  • Switch to personal workspace if the current selected workspace is same as that deleted.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@jamesgeorge007 jamesgeorge007 merged commit ba8c448 into release/2024.3.0 Mar 22, 2024
1 check passed
@jamesgeorge007 jamesgeorge007 deleted the fix/team-list-section-bugs branch March 22, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

@amk-dev amk-dev amk-dev approved these changes

@anwarulislam anwarulislam Awaiting requested review from anwarulislam anwarulislam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nivedin @jamesgeorge007 @amk-dev