Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): prevent exception with ShortcodeListAdapter initialization #3917

Merged

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Mar 20, 2024

Description

This PR aims at adding a safeguard to prevent an exception that can arise while attempting to initialize the ShortCodeListAdapter where the adapter is already initialized. This can happen while logging in on cloud with Shared Requests as the active tab.

Closes HFE-454.

Checks

  • My pull request adheres to the code style of this project
  • All the tests have passed

@jamesgeorge007 jamesgeorge007 changed the title fix(common): prevent exceptions with short code list adapter initialization fix(common): prevent exceptions with ShortcodeListAdapter initialization Mar 20, 2024
@jamesgeorge007 jamesgeorge007 changed the title fix(common): prevent exceptions with ShortcodeListAdapter initialization fix(common): prevent exception with ShortcodeListAdapter initialization Mar 20, 2024
@AndrewBastin AndrewBastin merged commit e533826 into hoppscotch:release/2024.3.0 Mar 20, 2024
1 check passed
@jamesgeorge007 jamesgeorge007 deleted the hotfix/share-requests branch March 20, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants