Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: can't import curl command with data-urlencode #3905

Merged
merged 5 commits into from Mar 25, 2024
Merged

fix: can't import curl command with data-urlencode #3905

merged 5 commits into from Mar 25, 2024

Conversation

shipko
Copy link
Contributor

@shipko shipko commented Mar 18, 2024

Closes #3901

Description

  • Not Completed
  • Completed

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@shipko shipko changed the title [bug]: can't import curl command with data-urlencode fix: can't import curl command with data-urlencode Mar 18, 2024
@anwarulislam anwarulislam self-requested a review March 19, 2024 12:52
anwarulislam
anwarulislam reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@anwarulislam anwarulislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider refactoring your code with fp-ts

@shipko
Copy link
Contributor Author

shipko commented Mar 23, 2024

@anwarulislam thanks!

@jamesgeorge007 jamesgeorge007 merged commit 1113c79 into hoppscotch:release/2024.3.0 Mar 25, 2024
1 check passed
@shipko shipko deleted the release/2024.3.0 branch April 14, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

@anwarulislam anwarulislam anwarulislam approved these changes

@amk-dev amk-dev Awaiting requested review from amk-dev amk-dev is a code owner

@AndrewBastin AndrewBastin Awaiting requested review from AndrewBastin AndrewBastin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shipko @jamesgeorge007 @anwarulislam