feat: team search in workspace search and spotlight #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amk-dev
force-pushed
the
feat/team-search-fe
branch
from
5452454
to
3fd84e9
Compare
amk-dev
requested review from
nivedin,
anwarulislam,
ankitsridhar16,
balub,
AndrewBastin and
liyasthomas
as code owners
nivedin
requested changes
Mar 15, 2024
jamesgeorge007
previously requested changes
Mar 15, 2024
jamesgeorge007
dismissed
their stale review
Ensuring the actions happening on the collection tree during search reflect immediately will require subscriptions to be set up for search results and will be handled separately.
@nivedin yes. it should. pushed a fix. |
jamesgeorge007
approved these changes
Mar 19, 2024
|
@amk-dev can you rebase this PR with the lastest changes, testing for FTS and for trigram have different edge cases I cannot test right now because the PR currently has the FTS implementation. |
nivedin
requested changes
Mar 19, 2024
|
@nivedin dismissing your review as it doesn't affect the critical flow atm. this can be improved in further iterations. |
nivedin
approved these changes
Mar 19, 2024
The search query being part of the endpoint, a network call with an empty search query results in a 404.
amk-dev
force-pushed
the
feat/team-search-fe
branch
from
7f71887
to
639d174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces searching team collections & requests from the workspace sidebar and spotlight search.