Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sh-admin): introducing additional SSO related server configurations to dashboard #3737

Merged
merged 13 commits into from Mar 8, 2024
Merged

feat(sh-admin): introducing additional SSO related server configurations to dashboard #3737

merged 13 commits into from Mar 8, 2024

Conversation

JoelJacobStephen
Copy link
Contributor

@JoelJacobStephen JoelJacobStephen commented Jan 9, 2024 •
edited

Ticket

Description

This PR enables the Admin Dashboard to show additional SSO related server configurations.

The additions to SSO Configurations include:

  • GOOGLE_CALLBACK_URL
  • GOOGLE_SCOPE
  • GITHUB_CALLBACK_URL
  • GITHUB_SCOPE
  • MICROSOFT_CALLBACK_URL
  • MICROSOFT_SCOPE
  • MICROSOFT_TENANT

Objectives

  • Admin Dashboard should include the additional SSO related server configurations in the Settings page under Auth Providers.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@JoelJacobStephen JoelJacobStephen self-assigned this Jan 9, 2024
@JoelJacobStephen JoelJacobStephen force-pushed the feat/dashboard-additional-configs branch from 7a8ac07 to 9c21966 Compare March 7, 2024 07:02
@JoelJacobStephen JoelJacobStephen changed the base branch from main to release/2024.3.0 March 7, 2024 07:02
@JoelJacobStephen JoelJacobStephen changed the title feat: introducing additional SSO related server configurations to admin dashboard feat(sh-admin): introducing additional SSO related server configurations to dashboard Mar 7, 2024
@JoelJacobStephen JoelJacobStephen force-pushed the feat/dashboard-additional-configs branch 2 times, most recently from 5629668 to 5acf834 Compare March 7, 2024 13:04
@JoelJacobStephen JoelJacobStephen marked this pull request as ready for review March 7, 2024 13:29
@JoelJacobStephen JoelJacobStephen force-pushed the feat/dashboard-additional-configs branch from e7d089b to f141cd4 Compare March 8, 2024 04:52
@JoelJacobStephen JoelJacobStephen removed their assignment Mar 8, 2024
@jamesgeorge007
chore: add suggestion from review
783b327 
- Derive types for provider fields from the base `Config` type.
- Unify markup.
jamesgeorge007
jamesgeorge007 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a few changes in 783b327, outlining the changes in the comments below along with a few pointers for future reference.

packages/hoppscotch-sh-admin/src/components/settings/AuthProvider.vue Show resolved Hide resolved
packages/hoppscotch-sh-admin/src/components/settings/AuthProvider.vue Show resolved Hide resolved
packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts Show resolved Hide resolved
packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts Show resolved Hide resolved
@AndrewBastin AndrewBastin merged commit e69d5a6 into hoppscotch:release/2024.3.0 Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

@anwarulislam anwarulislam Awaiting requested review from anwarulislam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoelJacobStephen @jamesgeorge007 @AndrewBastin